test_crawler_service.py
18.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
from __future__ import annotations
from services.application.crawler import (
CrawlerOperationConflictError,
CrawlerService,
CrawlerValidationError,
)
from services.application.research import ResearchTaskNotFoundError
from services.shared.config.access import DatabaseRuntimeSettings
from services.shared.dto import CrawlerJobDTO, ResearchTaskDTO
class _FakeCrawlerJobQueryService:
def __init__(self) -> None:
self.jobs_calls = 0
self.job_calls: list[str] = []
def build_crawler_jobs_payload(self) -> dict[str, object]:
self.jobs_calls += 1
return {
"current_job": {"id": "crawl-2"},
"jobs": [{"id": "crawl-2"}],
}
def build_crawler_job_payload(self, job_id: str) -> dict[str, object]:
self.job_calls.append(job_id)
return {
"job_id": job_id,
"crawler_job": {"id": job_id, "status": "running"},
}
def get_crawler_job_dto(self, job_id: str):
self.job_calls.append(job_id)
if not job_id:
return None
return CrawlerJobDTO(
id=job_id,
research_task_id="task-1",
platform="xiaohongshu",
keywords=["museum"],
status="running",
last_action="crawler started",
)
class _FakeLoginManager:
def __init__(self) -> None:
self.check_login_calls: list[dict[str, object]] = []
self.start_login_calls: list[dict[str, object]] = []
self.cancel_login_calls = 0
self.check_login_result = (True, {"platform": "xiaohongshu", "logged_in": True})
self.start_login_result = (True, "login started")
self.cancel_login_result = (True, "login cancelled")
def snapshot(self) -> dict[str, object]:
return {"active_task": {"running": False}}
def check_login(self, platform: str, headless: bool = True):
self.check_login_calls.append({"platform": platform, "headless": headless})
return self.check_login_result
def start_login(
self,
*,
platform: str,
login_type: str,
cookies: str = "",
phone: str = "",
headless: bool = True,
):
self.start_login_calls.append(
{
"platform": platform,
"login_type": login_type,
"cookies": cookies,
"phone": phone,
"headless": headless,
}
)
return self.start_login_result
def cancel_login(self):
self.cancel_login_calls += 1
return self.cancel_login_result
class _FakeCrawlManager:
def __init__(self) -> None:
self.start_calls: list[dict[str, object]] = []
self.stop_calls = 0
self.start_result = (True, "crawler started")
self.stop_result = (True, "crawler stopped")
self.snapshot_payload = {"status": "running", "history_id": "crawl-2"}
def snapshot(self) -> dict[str, object]:
return dict(self.snapshot_payload)
def start(self, payload: dict[str, object]):
self.start_calls.append(dict(payload))
return self.start_result
def stop(self):
self.stop_calls += 1
return self.stop_result
class _FakeUiStateStore:
def snapshot(self) -> dict[str, object]:
return {"history": []}
class _FakeResearchTaskService:
def __init__(self) -> None:
self.status_calls: list[dict[str, object]] = []
self.task_dtos = {
"task-1": ResearchTaskDTO(
id="task-1",
title="Museum Task",
status="ready",
generated_query="Museum Task generated query",
metadata={
"extras": {
"crawler_defaults": {
"keywords": ["Museum Task review", "Museum Task service"],
"crawler_type": "search",
"login_type": "qrcode",
"start_page": 3,
"max_notes": 50,
"max_comments": 12,
"enable_comments": True,
"enable_sub_comments": False,
},
"crawler_keywords_text": "Museum Task review\nMuseum Task service",
}
},
)
}
def get_task_dto(self, task_id: str) -> ResearchTaskDTO:
try:
return self.task_dtos[task_id]
except KeyError as exc:
raise ResearchTaskNotFoundError(f"missing task: {task_id}") from exc
def set_task_status(
self,
task_id: str,
*,
status: str,
last_action: str = "",
generated_query: str = "",
crawler_job_id: object = None,
):
self.status_calls.append(
{
"task_id": task_id,
"status": status,
"last_action": last_action,
"generated_query": generated_query,
"crawler_job_id": crawler_job_id,
}
)
return {"task_id": task_id}
def _build_service():
query_service = _FakeCrawlerJobQueryService()
login_manager = _FakeLoginManager()
crawl_manager = _FakeCrawlManager()
ui_state_store = _FakeUiStateStore()
research_task_service = _FakeResearchTaskService()
reload_calls: list[str] = []
service = CrawlerService(
crawl_manager=crawl_manager,
login_manager=login_manager,
ui_state_store=ui_state_store,
crawler_query_service=query_service,
valid_platforms=["xiaohongshu", "dianping"],
valid_login_types=["qrcode", "phone"],
reload_settings_callable=lambda: reload_calls.append("reloaded"),
database_runtime_settings_getter=lambda: DatabaseRuntimeSettings(
dialect="postgresql",
host="db",
port="5432",
user="bettafish",
password="bettafish",
name="bettafish",
charset="utf8mb4",
),
research_task_service=research_task_service,
)
return service, query_service, login_manager, crawl_manager, research_task_service, reload_calls
def test_build_crawler_state_payload_includes_snapshots_and_job_view():
service, query_service, _login_manager, _crawl_manager, _research_task_service, _reload_calls = _build_service()
payload = service.build_crawler_state_payload()
assert payload == {
"crawler": {"status": "running", "history_id": "crawl-2"},
"login": {"active_task": {"running": False}},
"storage": {"history": []},
"crawler_jobs": {
"current_job": {"id": "crawl-2"},
"jobs": [{"id": "crawl-2"}],
},
}
assert query_service.jobs_calls == 1
def test_build_crawler_jobs_payload_delegates_to_query_service():
service, query_service, _login_manager, _crawl_manager, _research_task_service, _reload_calls = _build_service()
payload = service.build_crawler_jobs_payload()
assert payload == {
"current_job": {"id": "crawl-2"},
"jobs": [{"id": "crawl-2"}],
}
assert query_service.jobs_calls == 1
def test_build_crawler_job_payload_delegates_to_query_service():
service, query_service, _login_manager, _crawl_manager, _research_task_service, _reload_calls = _build_service()
payload = service.build_crawler_job_payload("crawl-7")
assert payload == {
"job_id": "crawl-7",
"crawler_job": {"id": "crawl-7", "status": "running"},
}
assert query_service.job_calls == ["crawl-7"]
def test_get_default_save_option_uses_database_runtime_settings_boundary():
service, _query_service, _login_manager, _crawl_manager, _research_task_service, _reload_calls = _build_service()
assert service.get_default_save_option() == "postgres"
def test_check_login_returns_platform_state_payload():
service, _query_service, login_manager, _crawl_manager, _research_task_service, _reload_calls = _build_service()
payload = service.check_login(platform="xiaohongshu")
assert payload == {"platform_state": {"platform": "xiaohongshu", "logged_in": True}}
assert login_manager.check_login_calls == [{"platform": "xiaohongshu", "headless": True}]
def test_check_login_raises_validation_error_for_invalid_platform():
service, _query_service, _login_manager, _crawl_manager, _research_task_service, _reload_calls = _build_service()
try:
service.check_login(platform="")
assert False, "expected CrawlerValidationError"
except CrawlerValidationError as exc:
assert str(exc) == "Please choose a valid platform."
def test_check_login_raises_conflict_error_when_manager_rejects_request():
service, _query_service, login_manager, _crawl_manager, _research_task_service, _reload_calls = _build_service()
login_manager.check_login_result = (False, {"message": "login state is unavailable"})
try:
service.check_login(platform="xiaohongshu")
assert False, "expected CrawlerOperationConflictError"
except CrawlerOperationConflictError as exc:
assert str(exc) == "login state is unavailable"
def test_start_login_returns_message_payload():
service, _query_service, login_manager, _crawl_manager, _research_task_service, _reload_calls = _build_service()
payload = service.start_login(
platform="xiaohongshu",
login_type="qrcode",
cookies="cookie=1",
phone="13800138000",
)
assert payload == {"message": "login started"}
assert login_manager.start_login_calls == [
{
"platform": "xiaohongshu",
"login_type": "qrcode",
"cookies": "cookie=1",
"phone": "13800138000",
"headless": True,
}
]
def test_start_login_raises_validation_error_for_invalid_login_type():
service, _query_service, _login_manager, _crawl_manager, _research_task_service, _reload_calls = _build_service()
try:
service.start_login(platform="xiaohongshu", login_type="invalid-type")
assert False, "expected CrawlerValidationError"
except CrawlerValidationError as exc:
assert str(exc) == "Please choose a valid login type."
def test_start_login_raises_conflict_error_when_manager_rejects_request():
service, _query_service, login_manager, _crawl_manager, _research_task_service, _reload_calls = _build_service()
login_manager.start_login_result = (False, "login task already exists")
try:
service.start_login(platform="xiaohongshu", login_type="qrcode")
assert False, "expected CrawlerOperationConflictError"
except CrawlerOperationConflictError as exc:
assert str(exc) == "login task already exists"
def test_start_crawler_uses_metadata_extras_without_legacy_payload_fallback():
service, _query_service, _login_manager, crawl_manager, research_task_service, reload_calls = _build_service()
research_task_service.task_dtos["task-1"].legacy_payload = {}
payload = service.start_crawler(
{
"research_task_id": "task-1",
"platform": "xiaohongshu",
}
)
assert payload == {"message": "crawler started", "job_id": "crawl-2"}
assert reload_calls == ["reloaded"]
assert crawl_manager.start_calls == [
{
"research_task_id": "task-1",
"platform": "xiaohongshu",
"keywords": "Museum Task review\nMuseum Task service",
"crawler_type": "search",
"login_type": "qrcode",
"start_page": 3,
"max_notes": 50,
"max_comments": 12,
"enable_comments": True,
"enable_sub_comments": False,
}
]
def test_cancel_login_returns_message_payload():
service, _query_service, login_manager, _crawl_manager, _research_task_service, _reload_calls = _build_service()
payload = service.cancel_login()
assert payload == {"message": "login cancelled"}
assert login_manager.cancel_login_calls == 1
def test_cancel_login_raises_conflict_error_when_manager_rejects_request():
service, _query_service, login_manager, _crawl_manager, _research_task_service, _reload_calls = _build_service()
login_manager.cancel_login_result = (False, "login task is not running")
try:
service.cancel_login()
assert False, "expected CrawlerOperationConflictError"
except CrawlerOperationConflictError as exc:
assert str(exc) == "login task is not running"
def test_start_crawler_returns_message_payload_and_reloads_settings():
service, _query_service, _login_manager, crawl_manager, research_task_service, reload_calls = _build_service()
payload = service.start_crawler({"platform": "xiaohongshu", "keywords": ["museum"]})
assert payload == {"message": "crawler started", "job_id": "crawl-2"}
assert crawl_manager.start_calls == [{"platform": "xiaohongshu", "keywords": "museum"}]
assert reload_calls == ["reloaded"]
assert research_task_service.status_calls == []
def test_start_crawler_links_job_back_to_research_task_when_task_id_is_present():
service, _query_service, _login_manager, crawl_manager, research_task_service, reload_calls = _build_service()
payload = service.start_crawler({"platform": "xiaohongshu", "research_task_id": "task-1"})
assert payload == {"message": "crawler started", "job_id": "crawl-2"}
assert crawl_manager.start_calls == [
{
"platform": "xiaohongshu",
"research_task_id": "task-1",
"keywords": "Museum Task review\nMuseum Task service",
"crawler_type": "search",
"login_type": "qrcode",
"start_page": 3,
"max_notes": 50,
"max_comments": 12,
"enable_comments": True,
"enable_sub_comments": False,
}
]
assert reload_calls == ["reloaded"]
assert research_task_service.status_calls == [
{
"task_id": "task-1",
"status": "crawling",
"last_action": "crawler started",
"generated_query": "Museum Task generated query",
"crawler_job_id": "crawl-2",
}
]
def test_start_crawler_keeps_explicit_payload_over_research_task_defaults():
service, _query_service, _login_manager, crawl_manager, research_task_service, _reload_calls = _build_service()
service.start_crawler(
{
"platform": "xiaohongshu",
"research_task_id": "task-1",
"keywords": "custom keyword",
"login_type": "phone",
"start_page": 8,
"max_notes": 5,
"max_comments": 6,
"enable_comments": False,
"enable_sub_comments": True,
}
)
assert crawl_manager.start_calls == [
{
"platform": "xiaohongshu",
"research_task_id": "task-1",
"keywords": "custom keyword",
"crawler_type": "search",
"login_type": "phone",
"start_page": 8,
"max_notes": 5,
"max_comments": 6,
"enable_comments": False,
"enable_sub_comments": True,
}
]
assert research_task_service.status_calls[0]["generated_query"] == "Museum Task generated query"
def test_start_crawler_rejects_unknown_research_task_id():
service, _query_service, _login_manager, _crawl_manager, _research_task_service, _reload_calls = _build_service()
try:
service.start_crawler({"platform": "xiaohongshu", "research_task_id": "missing"})
assert False, "expected CrawlerValidationError"
except CrawlerValidationError as exc:
assert str(exc) == "Research task not found."
def test_start_crawler_raises_validation_error_for_invalid_platform():
service, _query_service, _login_manager, _crawl_manager, _research_task_service, _reload_calls = _build_service()
try:
service.start_crawler({"platform": ""})
assert False, "expected CrawlerValidationError"
except CrawlerValidationError as exc:
assert str(exc) == "Please choose a valid platform."
def test_start_crawler_raises_conflict_error_when_manager_rejects_request():
service, _query_service, _login_manager, crawl_manager, _research_task_service, reload_calls = _build_service()
crawl_manager.start_result = (False, "crawler is already running")
try:
service.start_crawler({"platform": "xiaohongshu"})
assert False, "expected CrawlerOperationConflictError"
except CrawlerOperationConflictError as exc:
assert str(exc) == "crawler is already running"
assert reload_calls == ["reloaded"]
def test_stop_crawler_returns_message_payload():
service, _query_service, _login_manager, crawl_manager, _research_task_service, _reload_calls = _build_service()
payload = service.stop_crawler()
assert payload == {"message": "crawler stopped"}
assert crawl_manager.stop_calls == 1
def test_stop_crawler_raises_conflict_error_when_manager_rejects_request():
service, _query_service, _login_manager, crawl_manager, _research_task_service, _reload_calls = _build_service()
crawl_manager.stop_result = (False, "crawler is not running")
try:
service.stop_crawler()
assert False, "expected CrawlerOperationConflictError"
except CrawlerOperationConflictError as exc:
assert str(exc) == "crawler is not running"
def test_build_task_crawler_resource_payload_returns_empty_resource_without_linked_job():
service, _query_service, _login_manager, _crawl_manager, _research_task_service, _reload_calls = _build_service()
payload = service.build_task_crawler_resource_payload(
research_task_id="task-1",
crawler_job_id=None,
task=ResearchTaskDTO(id="task-1", status="draft", last_action="draft task"),
)
assert payload["task_id"] == "task-1"
assert payload["crawler"]["crawler_job_id"] is None
assert payload["crawler"]["current_job"] is None
assert payload["crawler"]["jobs"] == []
assert payload["crawler"]["summary"]["status"] == "idle"
assert payload["crawler"]["history"]["has_jobs"] is False
def test_build_task_crawler_resource_payload_returns_linked_job_when_available():
service, _query_service, _login_manager, _crawl_manager, _research_task_service, _reload_calls = _build_service()
payload = service.build_task_crawler_resource_payload(
research_task_id="task-1",
crawler_job_id="crawl-7",
task=ResearchTaskDTO(id="task-1", status="crawling"),
)
assert payload["task_id"] == "task-1"
assert payload["crawler"]["crawler_job_id"] == "crawl-7"
assert payload["crawler"]["current_job"]["id"] == "crawl-7"
assert payload["crawler"]["jobs"][0]["id"] == "crawl-7"
assert payload["crawler"]["summary"]["status"] == "running"
assert payload["crawler"]["history"]["linked_job_available"] is True