hotfix: cherry pick updated yuvtorgb converter, fix resource not released

@@ -153,6 +153,7 @@ class MobileScanner(
 
 
                     bmResult.recycle()
                     bmResult.recycle()
                     imageProxy.close()
                     imageProxy.close()
+                    imageFormat.release()
 
 
                     mobileScannerCallback(
                     mobileScannerCallback(
                         barcodeMap,
                         barcodeMap,

@@ -2,18 +2,14 @@ package dev.steenbakker.mobile_scanner.utils
 
 
 import android.content.Context
 import android.content.Context
 import android.graphics.Bitmap
 import android.graphics.Bitmap
-import android.graphics.ImageFormat
 import android.media.Image
 import android.media.Image
-import android.os.Build
 import android.renderscript.Allocation
 import android.renderscript.Allocation
 import android.renderscript.Element
 import android.renderscript.Element
 import android.renderscript.RenderScript
 import android.renderscript.RenderScript
 import android.renderscript.ScriptIntrinsicYuvToRGB
 import android.renderscript.ScriptIntrinsicYuvToRGB
 import android.renderscript.Type
 import android.renderscript.Type
-import androidx.annotation.RequiresApi
 import java.nio.ByteBuffer
 import java.nio.ByteBuffer
 
 
-
 /**
 /**
  * Helper class used to efficiently convert a [Media.Image] object from
  * Helper class used to efficiently convert a [Media.Image] object from
  * YUV_420_888 format to an RGB [Bitmap] object.
  * YUV_420_888 format to an RGB [Bitmap] object.
@@ -23,59 +19,84 @@ import java.nio.ByteBuffer
  * The [yuvToRgb] method is able to achieve the same FPS as the CameraX image
  * The [yuvToRgb] method is able to achieve the same FPS as the CameraX image
  * analysis use case at the default analyzer resolution, which is 30 FPS with
  * analysis use case at the default analyzer resolution, which is 30 FPS with
  * 640x480 on a Pixel 3 XL device.
  * 640x480 on a Pixel 3 XL device.
- */class YuvToRgbConverter(context: Context) {
+ */
+/// TODO: Upgrade to implementation without deprecated android.renderscript, but with same or better performance. See https://github.com/juliansteenbakker/mobile_scanner/issues/1142
+class YuvToRgbConverter(context: Context) {
+    @Suppress("DEPRECATION")
     private val rs = RenderScript.create(context)
     private val rs = RenderScript.create(context)
+    @Suppress("DEPRECATION")
     private val scriptYuvToRgb =
     private val scriptYuvToRgb =
         ScriptIntrinsicYuvToRGB.create(rs, Element.U8_4(rs))
         ScriptIntrinsicYuvToRGB.create(rs, Element.U8_4(rs))
 
 
-    // Do not add getters/setters functions to these private variables
-    // because yuvToRgb() assume they won't be modified elsewhere
     private var yuvBits: ByteBuffer? = null
     private var yuvBits: ByteBuffer? = null
     private var bytes: ByteArray = ByteArray(0)
     private var bytes: ByteArray = ByteArray(0)
+    @Suppress("DEPRECATION")
     private var inputAllocation: Allocation? = null
     private var inputAllocation: Allocation? = null
+    @Suppress("DEPRECATION")
     private var outputAllocation: Allocation? = null
     private var outputAllocation: Allocation? = null
 
 
     @Synchronized
     @Synchronized
     fun yuvToRgb(image: Image, output: Bitmap) {
     fun yuvToRgb(image: Image, output: Bitmap) {
-        val yuvBuffer = YuvByteBuffer(image, yuvBits)
-        yuvBits = yuvBuffer.buffer
+        try {
+            val yuvBuffer = YuvByteBuffer(image, yuvBits)
+            yuvBits = yuvBuffer.buffer
 
 
-        if (needCreateAllocations(image, yuvBuffer)) {
-            val yuvType = Type.Builder(rs, Element.U8(rs))
-                .setX(image.width)
-                .setY(image.height)
-                .setYuvFormat(yuvBuffer.type)
-            inputAllocation = Allocation.createTyped(
-                rs,
-                yuvType.create(),
-                Allocation.USAGE_SCRIPT
-            )
-            bytes = ByteArray(yuvBuffer.buffer.capacity())
-            val rgbaType = Type.Builder(rs, Element.RGBA_8888(rs))
-                .setX(image.width)
-                .setY(image.height)
-            outputAllocation = Allocation.createTyped(
-                rs,
-                rgbaType.create(),
-                Allocation.USAGE_SCRIPT
-            )
-        }
+            if (needCreateAllocations(image, yuvBuffer)) {
+                createAllocations(image, yuvBuffer)
+            }
 
 
-        yuvBuffer.buffer.get(bytes)
-        inputAllocation!!.copyFrom(bytes)
+            yuvBuffer.buffer.get(bytes)
+            @Suppress("DEPRECATION")
+            inputAllocation!!.copyFrom(bytes)
 
 
-        // Convert NV21 or YUV_420_888 format to RGB
-        inputAllocation!!.copyFrom(bytes)
-        scriptYuvToRgb.setInput(inputAllocation)
-        scriptYuvToRgb.forEach(outputAllocation)
-        outputAllocation!!.copyTo(output)
+            @Suppress("DEPRECATION")
+            scriptYuvToRgb.setInput(inputAllocation)
+            @Suppress("DEPRECATION")
+            scriptYuvToRgb.forEach(outputAllocation)
+            @Suppress("DEPRECATION")
+            outputAllocation!!.copyTo(output)
+        } catch (e: Exception) {
+            throw IllegalStateException("Failed to convert YUV to RGB", e)
+        }
     }
     }
 
 
     private fun needCreateAllocations(image: Image, yuvBuffer: YuvByteBuffer): Boolean {
     private fun needCreateAllocations(image: Image, yuvBuffer: YuvByteBuffer): Boolean {
-        return (inputAllocation == null ||               // the very 1st call
-                inputAllocation!!.type.x != image.width ||   // image size changed
-                inputAllocation!!.type.y != image.height ||
-                inputAllocation!!.type.yuv != yuvBuffer.type || // image format changed
-                bytes.size == yuvBuffer.buffer.capacity())
+        @Suppress("DEPRECATION")
+        return inputAllocation?.type?.x != image.width ||
+                inputAllocation?.type?.y != image.height ||
+                inputAllocation?.type?.yuv != yuvBuffer.type
+    }
+
+    private fun createAllocations(image: Image, yuvBuffer: YuvByteBuffer) {
+        @Suppress("DEPRECATION")
+        val yuvType = Type.Builder(rs, Element.U8(rs))
+            .setX(image.width)
+            .setY(image.height)
+            .setYuvFormat(yuvBuffer.type)
+        @Suppress("DEPRECATION")
+        inputAllocation = Allocation.createTyped(
+            rs,
+            yuvType.create(),
+            Allocation.USAGE_SCRIPT
+        )
+        bytes = ByteArray(yuvBuffer.buffer.capacity())
+        @Suppress("DEPRECATION")
+        val rgbaType = Type.Builder(rs, Element.RGBA_8888(rs))
+            .setX(image.width)
+            .setY(image.height)
+        @Suppress("DEPRECATION")
+        outputAllocation = Allocation.createTyped(
+            rs,
+            rgbaType.create(),
+            Allocation.USAGE_SCRIPT
+        )
+    }
+
+    @Suppress("DEPRECATION")
+    fun release() {
+        inputAllocation?.destroy()
+        outputAllocation?.destroy()
+        scriptYuvToRgb.destroy()
+        rs.destroy()
     }
     }
 }
 }