Merge pull request #861 from vbuberen/update/nav_extensions_docs

Update offUntil and offNamedUntil docs

@@ -2,6 +2,7 @@ import 'dart:ui' as ui;
 
 
 import 'package:flutter/material.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter/scheduler.dart';
 import 'package:flutter/scheduler.dart';
+
 import '../../get_core/get_core.dart';
 import '../../get_core/get_core.dart';
 import '../../get_instance/src/bindings_interface.dart';
 import '../../get_instance/src/bindings_interface.dart';
 import '../../get_utils/get_utils.dart';
 import '../../get_utils/get_utils.dart';
@@ -592,11 +593,11 @@ extension GetNavigation on GetInterface {
   ///
   ///
   /// Obs: unlike other get methods, this one you need to send a function
   /// Obs: unlike other get methods, this one you need to send a function
   /// that returns the widget to the page argument, like this:
   /// that returns the widget to the page argument, like this:
-  /// Get.offUntil( () => HomePage() )
+  /// Get.offUntil(GetPageRoute(page: () => HomePage()), predicate)
   ///
   ///
   /// [predicate] can be used like this:
   /// [predicate] can be used like this:
-  /// `Get.until((route) => Get.currentRoute == '/home')`so when you get to home page,
-  ///
+  /// `Get.offUntil(page, (route) => (route as GetPageRoute).routeName == '/home')`
+  /// to pop routes in stack until home,
   /// or also like this:
   /// or also like this:
   /// `Get.until((route) => !Get.isDialogOpen())`, to make sure the dialog
   /// `Get.until((route) => !Get.isDialogOpen())`, to make sure the dialog
   /// is closed
   /// is closed
@@ -617,12 +618,13 @@ extension GetNavigation on GetInterface {
   /// as explained in documentation
   /// as explained in documentation
   ///
   ///
   /// [predicate] can be used like this:
   /// [predicate] can be used like this:
-  /// `Get.until((route) => Get.currentRoute == '/home')`so when you get to home page,
-  /// or also like
-  /// `Get.until((route) => !Get.isDialogOpen())`, to make sure the dialog
-  /// is closed
+  /// `Get.offNamedUntil(page, ModalRoute.withName('/home'))`
+  /// to pop routes in stack until home,
+  /// or like this:
+  /// `Get.offNamedUntil((route) => !Get.isDialogOpen())`,
+  /// to make sure the dialog is closed
   ///
   ///
-  /// Note: Always put a slash on the route ('/page1'), to avoid unnexpected errors
+  /// Note: Always put a slash on the route name ('/page1'), to avoid unexpected errors
   Future<T> offNamedUntil<T>(
   Future<T> offNamedUntil<T>(
     String page,
     String page,
     RoutePredicate predicate, {
     RoutePredicate predicate, {

 import 'package:flutter/material.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:get/get.dart';
 import 'package:get/get.dart';
+
 import 'utils/wrapper.dart';
 import 'utils/wrapper.dart';
 
 
 class SizeTransitions extends CustomTransition {
 class SizeTransitions extends CustomTransition {
@@ -198,16 +199,21 @@ void main() {
 
 
     await tester.pumpAndSettle();
     await tester.pumpAndSettle();
 
 
-    expect(find.byType(FirstScreen), findsOneWidget);
+    Get.to(SecondScreen());
 
 
-    Get.offUntil(
-      MaterialPageRoute(builder: (context) => SecondScreen()),
-      ModalRoute.withName('/'),
-    );
+    await tester.pumpAndSettle();
+
+    Get.offUntil(GetPageRoute(page: () => ThirdScreen()),
+        (route) => (route as GetPageRoute).routeName == '/FirstScreen');
 
 
     await tester.pumpAndSettle();
     await tester.pumpAndSettle();
 
 
-    expect(find.byType(SecondScreen), findsOneWidget);
+    expect(find.byType(ThirdScreen), findsOneWidget);
+    Get.back();
+
+    await tester.pumpAndSettle();
+
+    expect(find.byType(FirstScreen), findsOneWidget);
   });
   });
 
 
   testWidgets("Get.offNamedUntil smoke test", (tester) async {
   testWidgets("Get.offNamedUntil smoke test", (tester) async {
@@ -232,12 +238,19 @@ void main() {
     );
     );
 
 
     Get.toNamed('/first');
     Get.toNamed('/first');
+    Get.toNamed('/second');
 
 
     await tester.pumpAndSettle();
     await tester.pumpAndSettle();
 
 
-    expect(find.byType(FirstScreen), findsOneWidget);
+    expect(find.byType(SecondScreen), findsOneWidget);
+
+    Get.offNamedUntil('/third', ModalRoute.withName('/first'));
 
 
-    Get.offNamedUntil('/first', ModalRoute.withName('/'));
+    await tester.pumpAndSettle();
+
+    expect(find.byType(ThirdScreen), findsOneWidget);
+
+    Get.back();
 
 
     await tester.pumpAndSettle();
     await tester.pumpAndSettle();