flutter_package / fluttertpc_get

Go to a project
Toggle navigation Toggle navigation pinning
Jonny Borges
Committed by GitHub
414785e7 2 parents 2d54f9a4 a99091d2

Merge pull request #3067 from korutx/fix-parse-route 

Enhance Getx Route Parsing for HTTP/S App Links Compatibility
Inline Side-by-side
Showing 2 changed files with 16 additions and 9 deletions
... ... @@ -267,17 +267,17 @@ class ParseRouteTree {
Map<String, String> _parseParams(String path, PathDecoded routePath) {
final params = <String, String>{};
var idx = path.indexOf('?');
final uri = Uri.tryParse(path);
if (uri == null) return params;
if (idx > -1) {
path = path.substring(0, idx);
final uri = Uri.tryParse(path);
if (uri != null) {
params.addAll(uri.queryParameters);
}
params.addAll(uri.queryParameters);
}
var paramsMatch = routePath.regex.firstMatch(uri.path);
if (paramsMatch == null) {
return params;
}
var paramsMatch = routePath.regex.firstMatch(path);
for (var i = 0; i < routePath.keys.length; i++) {
var param = Uri.decodeQueryComponent(paramsMatch![i + 1]!);
var param = Uri.decodeQueryComponent(paramsMatch[i + 1]!);
params[routePath.keys[i]!] = param;
}
return params;
... ...
... ... @@ -135,7 +135,8 @@ void main() {
GetPage(page: () => Container(), name: '/first/:name'),
GetPage(page: () => Container(), name: '/second/:id'),
GetPage(page: () => Container(), name: '/third'),
GetPage(page: () => Container(), name: '/last/:id/:name/profile')
GetPage(page: () => Container(), name: '/last/:id/:name/profile'),
GetPage(page: () => Container(), name: '/first/second/:token')
],
));
... ... @@ -168,6 +169,12 @@ void main() {
expect(Get.parameters['id'], '1234');
expect(Get.parameters['name'], 'ana');
expect(Get.parameters['job'], 'dev');
Get.toNamed(
'https://www.example.com/first/second/fa9662f4-ec3f-11ee-a806-169a3915b383',
);
await tester.pumpAndSettle();
expect(Get.parameters['token'], 'fa9662f4-ec3f-11ee-a806-169a3915b383');
},
);
... ...