Committed by
GitHub
Merge pull request #2086 from Marplex/master
Improvement on RxSet: don't refresh() when adding an already present value
Showing
1 changed file
with
6 additions
and
4 deletions
@@ -34,10 +34,12 @@ class RxSet<E> extends GetListenable<Set<E>> | @@ -34,10 +34,12 @@ class RxSet<E> extends GetListenable<Set<E>> | ||
34 | } | 34 | } |
35 | 35 | ||
36 | @override | 36 | @override |
37 | - bool add(E newValue) { | ||
38 | - final val = value.add(newValue); | ||
39 | - refresh(); | ||
40 | - return val; | 37 | + bool add(E value) { |
38 | + final hasAdded = value.add(value); | ||
39 | + if (hasAdded) { | ||
40 | + refresh(); | ||
41 | + } | ||
42 | + return hasAdded; | ||
41 | } | 43 | } |
42 | 44 | ||
43 | @override | 45 | @override |
-
Please register or login to post a comment