Showing
2 changed files
with
8 additions
and
4 deletions
| @@ -2,8 +2,9 @@ | @@ -2,8 +2,9 @@ | ||
| 2 | 2 | ||
| 3 | * Cleaned up Android manifest. | 3 | * Cleaned up Android manifest. |
| 4 | * Changed a test name in `test_driver`. | 4 | * Changed a test name in `test_driver`. |
| 5 | -* Updated description. | 5 | +* Updated the plugin description. |
| 6 | * Updated `README.md`. | 6 | * Updated `README.md`. |
| 7 | +* Updated `CONTRIBUTING.md`. | ||
| 7 | * Removed unnecessary `Assets` directory from the `ios` folder. | 8 | * Removed unnecessary `Assets` directory from the `ios` folder. |
| 8 | 9 | ||
| 9 | ## 0.1.2+5 | 10 | ## 0.1.2+5 |
| @@ -17,8 +17,10 @@ The following steps are based on [flutter/plugin's contributing guide](https://g | @@ -17,8 +17,10 @@ The following steps are based on [flutter/plugin's contributing guide](https://g | ||
| 17 | * `git checkout upstream/master -b <name_of_your_branch>` | 17 | * `git checkout upstream/master -b <name_of_your_branch>` |
| 18 | * Now, you can change the code necessary for your patch. | 18 | * Now, you can change the code necessary for your patch. |
| 19 | 19 | ||
| 20 | - Make sure that you bump the version in [`pubspec.yaml`](https://github.com/creativecreatorormaybenot/wakelock/blob/master/pubspec.yaml) and add an entry to [`CHANGELOG.md`](https://github.com/creativecreatorormaybenot/wakelock/blob/master/CHANGELOG.md). | ||
| 21 | - The version format is `r.M.m+p`. You will want to increment one of these values and which one you increment depends on the impact of your patch: `p` for simple patches, `m` for minor versions, `M` for major versions, and `r` for released. Do not forget to reset the values to the right of the value you incremented to 0. You should omit `+0`. | 20 | + Make sure that you bump the version in [`pubspec.yaml`](https://github.com/creativecreatorormaybenot/wakelock/blob/master/pubspec.yaml) |
| 21 | + and add an entry to [`CHANGELOG.md`](https://github.com/creativecreatorormaybenot/wakelock/blob/master/CHANGELOG.md). | ||
| 22 | + The version format is `r.M.m+p`. You will want to increment one of these values and which one you increment depends on the impact of your patch: | ||
| 23 | + `p` for simple patches, `m` for minor versions, `M` for major versions, and `r` for released. Do not forget to reset the values to the right of the value you incremented to 0. You should omit `+0`. | ||
| 22 | * `git commit -am "<commit_message>"` | 24 | * `git commit -am "<commit_message>"` |
| 23 | * `git push origin <name_of_your_branch>` | 25 | * `git push origin <name_of_your_branch>` |
| 24 | 26 | ||
| @@ -31,7 +33,8 @@ Alternatively, you can also use `git pull-request` via [GitHub hub](https://hub. | @@ -31,7 +33,8 @@ Alternatively, you can also use `git pull-request` via [GitHub hub](https://hub. | ||
| 31 | * You should remember to exclude all files and directories your IDE might generate using the `.gitignore` files (if they do not already contain them for your IDE). | 33 | * You should remember to exclude all files and directories your IDE might generate using the `.gitignore` files (if they do not already contain them for your IDE). |
| 32 | If you feel like you can make useful additions to any of the `.gitignore` files, you can include them in your pull request, potentially with an explanation. | 34 | If you feel like you can make useful additions to any of the `.gitignore` files, you can include them in your pull request, potentially with an explanation. |
| 33 | 35 | ||
| 34 | - * It is probably easier for you to run the integration tests for the plugin locally using `flutter drive --target=test_driver/app.dart` in the `example` directory before opening a pull request (CI also runs the integration tests). | 36 | + * It is probably easier for you to run the integration tests for the plugin locally using `flutter drive --target=test_driver/app.dart` in the `example` directory |
| 37 | + before opening a pull request (CI also runs the integration tests). | ||
| 35 | This way you can ensure that any changes you have made work properly. Furthermore, you might also want to add some tests if you implement new functionality. | 38 | This way you can ensure that any changes you have made work properly. Furthermore, you might also want to add some tests if you implement new functionality. |
| 36 | 39 | ||
| 37 | * You should also run `flutter format lib example --fix` in the root directory and make sure that `flutter analyze` does not report any errors. | 40 | * You should also run `flutter format lib example --fix` in the root directory and make sure that `flutter analyze` does not report any errors. |
-
Please register or login to post a comment