David PHAM-VAN

Fix Health suggestions

@@ -198,8 +198,9 @@ orientation: $orientation'''; @@ -198,8 +198,9 @@ orientation: $orientation''';
198 } 198 }
199 final int offset = numValues > 4 ? valueOffset : (entryOffset + 8); 199 final int offset = numValues > 4 ? valueOffset : (entryOffset + 8);
200 final Uint8List result = Uint8List(numValues); 200 final Uint8List result = Uint8List(numValues);
201 - for (int i = 0; i < result.length; ++i) 201 + for (int i = 0; i < result.length; ++i) {
202 result[i] = file.getUint8(offset + i); 202 result[i] = file.getUint8(offset + i);
  203 + }
203 return result; 204 return result;
204 case 2: // ascii, 8-bit byte 205 case 2: // ascii, 8-bit byte
205 final int offset = numValues > 4 ? valueOffset : (entryOffset + 8); 206 final int offset = numValues > 4 ? valueOffset : (entryOffset + 8);
@@ -210,8 +211,9 @@ orientation: $orientation'''; @@ -210,8 +211,9 @@ orientation: $orientation''';
210 } 211 }
211 final int offset = numValues > 2 ? valueOffset : (entryOffset + 8); 212 final int offset = numValues > 2 ? valueOffset : (entryOffset + 8);
212 final Uint16List result = Uint16List(numValues); 213 final Uint16List result = Uint16List(numValues);
213 - for (int i = 0; i < result.length; ++i) 214 + for (int i = 0; i < result.length; ++i) {
214 result[i] = file.getUint16(offset + i * 2, bigEnd); 215 result[i] = file.getUint16(offset + i * 2, bigEnd);
  216 + }
215 return result; 217 return result;
216 case 4: // long, 32 bit int 218 case 4: // long, 32 bit int
217 if (numValues == 1) { 219 if (numValues == 1) {
@@ -219,8 +221,9 @@ orientation: $orientation'''; @@ -219,8 +221,9 @@ orientation: $orientation''';
219 } 221 }
220 final int offset = valueOffset; 222 final int offset = valueOffset;
221 final Uint32List result = Uint32List(numValues); 223 final Uint32List result = Uint32List(numValues);
222 - for (int i = 0; i < result.length; ++i) 224 + for (int i = 0; i < result.length; ++i) {
223 result[i] = file.getUint32(offset + i * 4, bigEnd); 225 result[i] = file.getUint32(offset + i * 4, bigEnd);
  226 + }
224 return result; 227 return result;
225 case 5: // rational = two long values, first is numerator, second is denominator 228 case 5: // rational = two long values, first is numerator, second is denominator
226 if (numValues == 1) { 229 if (numValues == 1) {
@@ -242,8 +245,9 @@ orientation: $orientation'''; @@ -242,8 +245,9 @@ orientation: $orientation''';
242 } 245 }
243 final int offset = valueOffset; 246 final int offset = valueOffset;
244 final Int32List result = Int32List(numValues); 247 final Int32List result = Int32List(numValues);
245 - for (int i = 0; i < result.length; ++i) 248 + for (int i = 0; i < result.length; ++i) {
246 result[i] = file.getInt32(offset + i * 4, bigEnd); 249 result[i] = file.getInt32(offset + i * 4, bigEnd);
  250 + }
247 return result; 251 return result;
248 case 10: // signed rational, two slongs, first is numerator, second is denominator 252 case 10: // signed rational, two slongs, first is numerator, second is denominator
249 if (numValues == 1) { 253 if (numValues == 1) {
@@ -265,8 +269,9 @@ orientation: $orientation'''; @@ -265,8 +269,9 @@ orientation: $orientation''';
265 } 269 }
266 final int offset = valueOffset; 270 final int offset = valueOffset;
267 final Float32List result = Float32List(numValues); 271 final Float32List result = Float32List(numValues);
268 - for (int i = 0; i < result.length; ++i) 272 + for (int i = 0; i < result.length; ++i) {
269 result[i] = file.getFloat32(offset + i * 4, bigEnd); 273 result[i] = file.getFloat32(offset + i * 4, bigEnd);
  274 + }
270 return result; 275 return result;
271 case 12: // double float, 64 bit float 276 case 12: // double float, 64 bit float
272 if (numValues == 1) { 277 if (numValues == 1) {
@@ -274,8 +279,9 @@ orientation: $orientation'''; @@ -274,8 +279,9 @@ orientation: $orientation''';
274 } 279 }
275 final int offset = valueOffset; 280 final int offset = valueOffset;
276 final Float64List result = Float64List(numValues); 281 final Float64List result = Float64List(numValues);
277 - for (int i = 0; i < result.length; ++i) 282 + for (int i = 0; i < result.length; ++i) {
278 result[i] = file.getFloat64(offset + i * 8, bigEnd); 283 result[i] = file.getFloat64(offset + i * 8, bigEnd);
  284 + }
279 return result; 285 return result;
280 } 286 }
281 } 287 }