imp: remove redundant internalController

@@ -51,16 +51,7 @@ class _MobileScannerState extends State<MobileScanner>
   StreamSubscription<BarcodeCapture>? _barcodesSubscription;
   StreamSubscription<BarcodeCapture>? _barcodesSubscription;
 
 
   /// The internally managed controller.
   /// The internally managed controller.
-  MobileScannerController? _controller;
-
-  /// Get the effective controller.
-  MobileScannerController get _effectiveController {
-    if (widget.controller != null) {
-      return widget.controller!;
-    }
-
-    return _controller!;
-  }
+  late MobileScannerController _controller;
 
 
   /// Whether the controller should resume
   /// Whether the controller should resume
   /// when the application comes back to the foreground.
   /// when the application comes back to the foreground.
@@ -80,40 +71,35 @@ class _MobileScannerState extends State<MobileScanner>
   void initState() {
   void initState() {
     super.initState();
     super.initState();
     WidgetsBinding.instance.addObserver(this);
     WidgetsBinding.instance.addObserver(this);
+    _controller = widget.controller ?? MobileScannerController();
     
     
-    if (widget.controller == null) {
-      _controller = MobileScannerController();
-    }
-
-    _barcodesSubscription = _effectiveController.barcodes.listen(
+    _barcodesSubscription = _controller.barcodes.listen(
       widget.onDetect,
       widget.onDetect,
     );
     );
 
 
-    final internalController = _controller;
-
-    if (internalController != null && !internalController.isStarting) {
-      _startScanner(internalController);
+    if (!_controller.isStarting) {
+      _startScanner(_controller);
     }
     }
   }
   }
 
 
   @override
   @override
   void didChangeAppLifecycleState(AppLifecycleState state) {
   void didChangeAppLifecycleState(AppLifecycleState state) {
     // App state changed before the controller was initialized.
     // App state changed before the controller was initialized.
-    if (_effectiveController.isStarting) {
+    if (_controller.isStarting) {
       return;
       return;
     }
     }
 
 
     switch (state) {
     switch (state) {
       case AppLifecycleState.resumed:
       case AppLifecycleState.resumed:
         _resumeFromBackground = false;
         _resumeFromBackground = false;
-        _startScanner(_effectiveController);
+        _startScanner(_controller);
         break;
         break;
       case AppLifecycleState.paused:
       case AppLifecycleState.paused:
         _resumeFromBackground = true;
         _resumeFromBackground = true;
         break;
         break;
       case AppLifecycleState.inactive:
       case AppLifecycleState.inactive:
         if (!_resumeFromBackground) {
         if (!_resumeFromBackground) {
-          _effectiveController.stop();
+          _controller.stop();
         }
         }
         break;
         break;
       case AppLifecycleState.detached:
       case AppLifecycleState.detached:
@@ -122,27 +108,9 @@ class _MobileScannerState extends State<MobileScanner>
   }
   }
 
 
   @override
   @override
-  void didUpdateWidget(covariant MobileScanner oldWidget) {
-    super.didUpdateWidget(oldWidget);
-
-    if (oldWidget.controller == null) {
-      if (widget.controller != null) {
-        _controller?.dispose();
-        _controller = widget.controller;
-      }
-    } else {
-      if (widget.controller == null) {
-        _controller = MobileScannerController();
-      } else if (oldWidget.controller != widget.controller) {
-        _controller = widget.controller;
-      }
-    }
-  }
-
-  @override
   Widget build(BuildContext context) {
   Widget build(BuildContext context) {
     return ValueListenableBuilder<MobileScannerArguments?>(
     return ValueListenableBuilder<MobileScannerArguments?>(
-      valueListenable: _effectiveController.startArguments,
+      valueListenable: _controller.startArguments,
       builder: (context, value, child) {
       builder: (context, value, child) {
         if (value == null) {
         if (value == null) {
           return widget.placeholderBuilder?.call(context, child) ??
           return widget.placeholderBuilder?.call(context, child) ??
@@ -176,7 +144,7 @@ class _MobileScannerState extends State<MobileScanner>
   void dispose() {
   void dispose() {
     WidgetsBinding.instance.removeObserver(this);
     WidgetsBinding.instance.removeObserver(this);
     _barcodesSubscription?.cancel();
     _barcodesSubscription?.cancel();
-    _controller?.dispose();
+    _controller.dispose();
     super.dispose();
     super.dispose();
   }
   }
 }
 }