Showing
2 changed files
with
4 additions
and
2 deletions
| @@ -214,7 +214,8 @@ class GetDelegate extends RouterDelegate<GetPage> | @@ -214,7 +214,8 @@ class GetDelegate extends RouterDelegate<GetPage> | ||
| 214 | } | 214 | } | 
| 215 | 215 | ||
| 216 | void _currentRouteChanged(GetPageRoute route) { | 216 | void _currentRouteChanged(GetPageRoute route) { | 
| 217 | - //transition? | 217 | + //is this method useful ? | 
| 218 | + //transition? -> in router outlet ?? | ||
| 218 | //buildPage? -> in router outlet | 219 | //buildPage? -> in router outlet | 
| 219 | } | 220 | } | 
| 220 | } | 221 | } | 
| @@ -89,6 +89,7 @@ class GetRouterOutlet extends RouterOutlet<GetDelegate, GetPage> { | @@ -89,6 +89,7 @@ class GetRouterOutlet extends RouterOutlet<GetDelegate, GetPage> { | ||
| 89 | pageBuilder: (context, rDelegate, page) { | 89 | pageBuilder: (context, rDelegate, page) { | 
| 90 | final pageRoute = rDelegate.pageRoutes[page]; | 90 | final pageRoute = rDelegate.pageRoutes[page]; | 
| 91 | if (pageRoute != null) { | 91 | if (pageRoute != null) { | 
| 92 | + //TODO: transitions go here ! | ||
| 92 | return pageRoute.buildPage( | 93 | return pageRoute.buildPage( | 
| 93 | context, | 94 | context, | 
| 94 | pageRoute.animation, | 95 | pageRoute.animation, | 
| @@ -96,7 +97,7 @@ class GetRouterOutlet extends RouterOutlet<GetDelegate, GetPage> { | @@ -96,7 +97,7 @@ class GetRouterOutlet extends RouterOutlet<GetDelegate, GetPage> { | ||
| 96 | ); | 97 | ); | 
| 97 | } | 98 | } | 
| 98 | 99 | ||
| 99 | - /// improve this logic abit | 100 | + /// TODO: improve this logic abit | 
| 100 | return (emptyPage?.call(rDelegate) ?? | 101 | return (emptyPage?.call(rDelegate) ?? | 
| 101 | rDelegate.notFoundRoute?.page()) ?? | 102 | rDelegate.notFoundRoute?.page()) ?? | 
| 102 | SizedBox.shrink(); | 103 | SizedBox.shrink(); | 
- 
Please register or login to post a comment