Merge pull request #2740 from jonataslaw/fix-theme-and-rxlist

Release candidate 4

+## [5.0.0-release-candidate-4]
+-Fix changeThemeMode and RxList
+
+## [5.0.0-release-candidate-3]
+-Fix changeTheme
+
 ## [5.0.0-release-candidate-2]
 This version adds built-in support for animation in Flutter in an easy, clear way, and without having to create a StatefulWidget with controllers and animations. All you need to do is call the name of the animation.
 

@@ -4,7 +4,7 @@
 # This file should be version controlled.
 
 version:
-  revision: 9944297138845a94256f1cf37beb88ff9a8e811a
+  revision: c07f7888888435fd9df505aa2efc38d3cf65681b
   channel: stable
 
 project_type: app
@@ -13,26 +13,26 @@ project_type: app
 migration:
   platforms:
     - platform: root
-      create_revision: 9944297138845a94256f1cf37beb88ff9a8e811a
-      base_revision: 9944297138845a94256f1cf37beb88ff9a8e811a
+      create_revision: c07f7888888435fd9df505aa2efc38d3cf65681b
+      base_revision: c07f7888888435fd9df505aa2efc38d3cf65681b
     - platform: android
-      create_revision: 9944297138845a94256f1cf37beb88ff9a8e811a
-      base_revision: 9944297138845a94256f1cf37beb88ff9a8e811a
+      create_revision: c07f7888888435fd9df505aa2efc38d3cf65681b
+      base_revision: c07f7888888435fd9df505aa2efc38d3cf65681b
     - platform: ios
-      create_revision: 9944297138845a94256f1cf37beb88ff9a8e811a
-      base_revision: 9944297138845a94256f1cf37beb88ff9a8e811a
+      create_revision: c07f7888888435fd9df505aa2efc38d3cf65681b
+      base_revision: c07f7888888435fd9df505aa2efc38d3cf65681b
     - platform: linux
-      create_revision: 9944297138845a94256f1cf37beb88ff9a8e811a
-      base_revision: 9944297138845a94256f1cf37beb88ff9a8e811a
+      create_revision: c07f7888888435fd9df505aa2efc38d3cf65681b
+      base_revision: c07f7888888435fd9df505aa2efc38d3cf65681b
     - platform: macos
-      create_revision: 9944297138845a94256f1cf37beb88ff9a8e811a
-      base_revision: 9944297138845a94256f1cf37beb88ff9a8e811a
+      create_revision: c07f7888888435fd9df505aa2efc38d3cf65681b
+      base_revision: c07f7888888435fd9df505aa2efc38d3cf65681b
     - platform: web
-      create_revision: 9944297138845a94256f1cf37beb88ff9a8e811a
-      base_revision: 9944297138845a94256f1cf37beb88ff9a8e811a
+      create_revision: c07f7888888435fd9df505aa2efc38d3cf65681b
+      base_revision: c07f7888888435fd9df505aa2efc38d3cf65681b
     - platform: windows
-      create_revision: 9944297138845a94256f1cf37beb88ff9a8e811a
-      base_revision: 9944297138845a94256f1cf37beb88ff9a8e811a
+      create_revision: c07f7888888435fd9df505aa2efc38d3cf65681b
+      base_revision: c07f7888888435fd9df505aa2efc38d3cf65681b
 
   # User provided section
 

@@ -29,27 +29,27 @@ class MyApp extends StatelessWidget {
 
 /// Nav 2 snippet
 // void main() {
-//   runApp(MyApp());
+//   runApp(const MyApp());
 // }
 
 // class MyApp extends StatelessWidget {
-//   MyApp({Key? key}) : super(key: key);
+//   const MyApp({Key? key}) : super(key: key);
 
 //   @override
 //   Widget build(BuildContext context) {
-//     return GetMaterialApp.router(
+//     return GetMaterialApp(
 //       getPages: [
 //         GetPage(
 //             participatesInRootNavigator: true,
 //             name: '/first',
-//             page: () => First()),
+//             page: () => const First()),
 //         GetPage(
 //           name: '/second',
-//           page: () => Second(),
+//           page: () => const Second(),
 //         ),
 //         GetPage(
 //           name: '/third',
-//           page: () => Third(),
+//           page: () => const Third(),
 //         ),
 //       ],
 //       debugShowCheckedModeBanner: false,
@@ -58,26 +58,32 @@ class MyApp extends StatelessWidget {
 // }
 
 // class First extends StatelessWidget {
+//   const First({Key? key}) : super(key: key);
+
 //   @override
 //   Widget build(BuildContext context) {
+//     print('First rebuild');
 //     return Scaffold(
 //       appBar: AppBar(
-//         title: Text('page one'),
+//         title: const Text('page one'),
 //         leading: IconButton(
-//           icon: Icon(Icons.more),
+//           icon: const Icon(Icons.more),
 //           onPressed: () {
+//             print('THEME CHANGED');
 //             Get.changeTheme(
-//                 context.isDarkMode ? ThemeData.light() : ThemeData.dark());
+//                 Get.isDarkMode ? ThemeData.light() : ThemeData.dark());
 //           },
 //         ),
 //       ),
 //       body: Center(
-//         child: Container(
+//         child: SizedBox(
 //           height: 300,
 //           width: 300,
 //           child: ElevatedButton(
-//             onPressed: () {},
-//             child: Text('next screen'),
+//             onPressed: () {
+//               Get.toNamed('/second?id=123');
+//             },
+//             child: const Text('next screen'),
 //           ),
 //         ),
 //       ),
@@ -86,19 +92,22 @@ class MyApp extends StatelessWidget {
 // }
 
 // class Second extends StatelessWidget {
+//   const Second({Key? key}) : super(key: key);
+
 //   @override
 //   Widget build(BuildContext context) {
+//     print('second rebuild');
 //     return Scaffold(
 //       appBar: AppBar(
 //         title: Text('page two ${Get.parameters["id"]}'),
 //       ),
 //       body: Center(
-//         child: Container(
+//         child: SizedBox(
 //           height: 300,
 //           width: 300,
 //           child: ElevatedButton(
 //             onPressed: () {},
-//             child: Text('next screen'),
+//             child: const Text('next screen'),
 //           ),
 //         ),
 //       ),
@@ -107,20 +116,22 @@ class MyApp extends StatelessWidget {
 // }
 
 // class Third extends StatelessWidget {
+//   const Third({Key? key}) : super(key: key);
+
 //   @override
 //   Widget build(BuildContext context) {
 //     return Scaffold(
 //       backgroundColor: Colors.red,
 //       appBar: AppBar(
-//         title: Text('page three'),
+//         title: const Text('page three'),
 //       ),
 //       body: Center(
-//         child: Container(
+//         child: SizedBox(
 //           height: 300,
 //           width: 300,
 //           child: ElevatedButton(
 //             onPressed: () {},
-//             child: Text('go to first screen'),
+//             child: const Text('go to first screen'),
 //           ),
 //         ),
 //       ),

@@ -438,7 +438,7 @@ class GetRootState extends State<GetRoot> with WidgetsBindingObserver {
   }
 
   Transition? getThemeTransition() {
-    final platform = Get.theme.platform;
+    final platform = context.theme.platform;
     final matchingTransition =
         Get.theme.pageTransitionsTheme.builders[platform];
     switch (matchingTransition) {
@@ -489,7 +489,10 @@ class GetRootState extends State<GetRoot> with WidgetsBindingObserver {
   }
 
   void update() {
-    setState(() {});
+    context.visitAncestorElements((element) {
+      element.markNeedsBuild();
+      return false;
+    });
   }
 
   GlobalKey<NavigatorState> get key => rootDelegate.navigatorKey;

@@ -48,7 +48,7 @@ class RxList<E> extends GetListenable<List<E>>
   @override
   RxList<E> operator +(Iterable<E> val) {
     addAll(val);
-    refresh();
+    // refresh();
     return this;
   }
 
@@ -113,11 +113,11 @@ class RxList<E> extends GetListenable<List<E>>
   @override
   Iterable<E> get reversed => value.reversed;
 
-  @override
-  set value(List<E> val) {
-    value = val;
-    refresh();
-  }
+  // @override
+  // set value(List<E> val) {
+  //   value = val;
+  //   refresh();
+  // }
 
   @override
   Iterable<E> where(bool Function(E) test) {

@@ -8,7 +8,7 @@ class RxSet<E> extends GetListenable<Set<E>>
   /// inside the List,
   RxSet<E> operator +(Set<E> val) {
     addAll(val);
-    refresh();
+    //refresh();
     return this;
   }
 
@@ -25,13 +25,13 @@ class RxSet<E> extends GetListenable<Set<E>>
   //   // return _value;
   // }
 
-  @override
-  @protected
-  set value(Set<E> val) {
-    if (value == val) return;
-    value = val;
-    refresh();
-  }
+  // @override
+  // @protected
+  // set value(Set<E> val) {
+  //   if (value == val) return;
+  //   value = val;
+  //   refresh();
+  // }
 
   @override
   bool add(E value) {

 name: get
 description: Open screens/snackbars/dialogs without context, manage states and inject dependencies easily with GetX.
-version: 5.0.0-release-candidate-2
+version: 5.0.0-release-candidate-4
 homepage: https://github.com/jonataslaw/getx
 
 environment: