Showing
2 changed files
with
5 additions
and
6 deletions
@@ -20,8 +20,7 @@ jobs: | @@ -20,8 +20,7 @@ jobs: | ||
20 | flutter-version: '1.20.2' | 20 | flutter-version: '1.20.2' |
21 | channel: 'stable' | 21 | channel: 'stable' |
22 | - run: flutter pub get | 22 | - run: flutter pub get |
23 | - # run static analys code | ||
24 | - #- run: flutter analyze | 23 | + - run: flutter analyze |
25 | # run flutter widgets tests and unit tests | 24 | # run flutter widgets tests and unit tests |
26 | - run: flutter test --coverage | 25 | - run: flutter test --coverage |
27 | # Upload coverage reports to Codecov | 26 | # Upload coverage reports to Codecov |
@@ -27,6 +27,7 @@ typedef GetStateUpdate = bool Function(); | @@ -27,6 +27,7 @@ typedef GetStateUpdate = bool Function(); | ||
27 | // TODO: check performance HIT for the extra method call. | 27 | // TODO: check performance HIT for the extra method call. |
28 | mixin GetStateUpdaterMixin<T extends StatefulWidget> on State<T> { | 28 | mixin GetStateUpdaterMixin<T extends StatefulWidget> on State<T> { |
29 | // To avoid the creation of an anonym function to be GC later. | 29 | // To avoid the creation of an anonym function to be GC later. |
30 | + // ignore: prefer_function_declarations_over_variables | ||
30 | static final VoidCallback _stateCallback = () {}; | 31 | static final VoidCallback _stateCallback = () {}; |
31 | 32 | ||
32 | /// Experimental method to replace setState((){}); | 33 | /// Experimental method to replace setState((){}); |
@@ -68,12 +69,11 @@ class GetxController extends DisposableInterface { | @@ -68,12 +69,11 @@ class GetxController extends DisposableInterface { | ||
68 | // for (final rs in _updatersGroupIds[id]) rs(); | 69 | // for (final rs in _updatersGroupIds[id]) rs(); |
69 | // } | 70 | // } |
70 | 71 | ||
71 | - ids.forEach((id) { | ||
72 | -// _updatersIds[id]?.call(() {}); //<old> | ||
73 | -// _updatersGroupIds[id]?.forEach((rs) => rs(() {})); //<old> | 72 | + for (final id in ids) { |
74 | _updatersIds[id]?.call(); | 73 | _updatersIds[id]?.call(); |
74 | + // ignore: avoid_function_literals_in_foreach_calls | ||
75 | _updatersGroupIds[id]?.forEach((rs) => rs()); | 75 | _updatersGroupIds[id]?.forEach((rs) => rs()); |
76 | - }); | 76 | + } |
77 | } | 77 | } |
78 | } | 78 | } |
79 | 79 |
-
Please register or login to post a comment