David PHAM-VAN

Improve Web Browser detection logic

1 # Changelog 1 # Changelog
2 2
  3 +## 5.13.4
  4 +
  5 +- Improve Web Browser detection logic
  6 +
3 ## 5.13.3 7 ## 5.13.3
4 8
5 - Update gfonts [Minh-Danh] 9 - Update gfonts [Minh-Danh]
@@ -191,12 +191,13 @@ class PrintingPlugin extends PrintingPlatform { @@ -191,12 +191,13 @@ class PrintingPlugin extends PrintingPlatform {
191 return false; 191 return false;
192 } 192 }
193 193
  194 + // UserAgent can contain both Chrome and Safari for Chrome browser.
  195 + // UserAgent contains only Safari for Safari browser.
194 final userAgent = web.window.navigator.userAgent; 196 final userAgent = web.window.navigator.userAgent;
195 - final isChrome = web.window['chrome'].isUndefinedOrNull;  
196 - final isSafari = web.window['safari'].isUndefinedOrNull &&  
197 - !userAgent.contains(RegExp(r'Version/14\.1\.'));  
198 - final isMobile = userAgent.contains('Mobile'); 197 + final isChrome = userAgent.contains('Chrome');
  198 + final isSafari = userAgent.contains('Safari') && !isChrome;
199 final isFirefox = userAgent.contains('Firefox'); 199 final isFirefox = userAgent.contains('Firefox');
  200 + final isMobile = userAgent.contains('Mobile');
200 201
201 // Chrome, Safari, and Firefox on a desktop computer 202 // Chrome, Safari, and Firefox on a desktop computer
202 if ((isChrome || isSafari || isFirefox) && !isMobile) { 203 if ((isChrome || isSafari || isFirefox) && !isMobile) {
@@ -15,7 +15,7 @@ topics: @@ -15,7 +15,7 @@ topics:
15 - print 15 - print
16 - printing 16 - printing
17 - report 17 - report
18 -version: 5.13.3 18 +version: 5.13.4
19 19
20 environment: 20 environment:
21 sdk: ">=3.3.0 <4.0.0" 21 sdk: ">=3.3.0 <4.0.0"