Committed by
GitHub
Throw multi pages error explicitly (#1455)
Showing
3 changed files
with
13 additions
and
5 deletions
| @@ -246,14 +246,11 @@ class MultiPage extends Page { | @@ -246,14 +246,11 @@ class MultiPage extends Page { | ||
| 246 | while (_index < children.length) { | 246 | while (_index < children.length) { |
| 247 | final child = children[_index]; | 247 | final child = children[_index]; |
| 248 | 248 | ||
| 249 | - assert(() { | ||
| 250 | // Detect too big widgets | 249 | // Detect too big widgets |
| 251 | if (sameCount++ > maxPages) { | 250 | if (sameCount++ > maxPages) { |
| 252 | - throw Exception( | 251 | + throw TooManyPagesException( |
| 253 | 'This widget created more than $maxPages pages. This may be an issue in the widget or the document. See https://pub.dev/documentation/pdf/latest/widgets/MultiPage-class.html'); | 252 | 'This widget created more than $maxPages pages. This may be an issue in the widget or the document. See https://pub.dev/documentation/pdf/latest/widgets/MultiPage-class.html'); |
| 254 | } | 253 | } |
| 255 | - return true; | ||
| 256 | - }()); | ||
| 257 | 254 | ||
| 258 | // Create a new page if we don't already have one | 255 | // Create a new page if we don't already have one |
| 259 | if (context == null || child is NewPage) { | 256 | if (context == null || child is NewPage) { |
| @@ -579,3 +576,10 @@ class MultiPage extends Page { | @@ -579,3 +576,10 @@ class MultiPage extends Page { | ||
| 579 | } | 576 | } |
| 580 | } | 577 | } |
| 581 | } | 578 | } |
| 579 | + | ||
| 580 | +/// Exception thrown when generator populates more pages than [maxPages]. | ||
| 581 | +class TooManyPagesException implements Exception { | ||
| 582 | + TooManyPagesException(this.message); | ||
| 583 | + | ||
| 584 | + final String message; | ||
| 585 | +} |
| @@ -6,7 +6,7 @@ issue_tracker: https://github.com/DavBfr/dart_pdf/issues | @@ -6,7 +6,7 @@ issue_tracker: https://github.com/DavBfr/dart_pdf/issues | ||
| 6 | screenshots: | 6 | screenshots: |
| 7 | - description: 'Example of a generated document' | 7 | - description: 'Example of a generated document' |
| 8 | path: example.jpg | 8 | path: example.jpg |
| 9 | -version: 3.10.5 | 9 | +version: 3.10.6 |
| 10 | 10 | ||
| 11 | environment: | 11 | environment: |
| 12 | sdk: ">=2.18.0 <4.0.0" | 12 | sdk: ">=2.18.0 <4.0.0" |
-
Please register or login to post a comment